[ 
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607560#comment-13607560
 ] 

Uwe Schindler commented on LUCENE-4848:
---------------------------------------

Robert: I agree. I will split the patch and provide one on this thread only 
with the refactoring done in the already-existing directories.

The thing with windows was that the RAF-based file channel had the problem of 
some kind of synchronization internally in Sun's implementation. We should 
validate with the new and patched NIOFSDirectory if this is still the case with 
the *completely different* FileChannel (it is different class, different 
FileDescriptor-type,...) implementation returned by FileChannel.open(). If this 
*new* implementation fixes the old Sun Micrososystems synchronization issues in 
NIO v1, we can mark NIOFSDirectory working correctly in Windows with Lucene 
trunk / Java 7 and we are fine. So we need to benchmark this.

I dont really like the AsyncFSDirectory, because it looks like a "workaround". 
If NIOFSDir is now working on windows, we don't need it.
                
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
>                 Key: LUCENE-4848
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4848
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Michael Poindexter
>            Assignee: Uwe Schindler
>            Priority: Minor
>         Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch, 
> LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, 
> LUCENE-4848.patch.txt
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on 
> JDK7).  These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5 
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue.  I'll be happy to make any 
> changes requested.  I've included some minimal smoke tests, but any help in 
> how to use the normal Lucene tests to perform more thorough testing would be 
> appreciated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to