[
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607507#comment-13607507
]
Uwe Schindler commented on LUCENE-4848:
---------------------------------------
bq. Regarding the 2 new abstract methods in the base class: I'm fine with
making the length be passed in the constructor, which leaves isFDValid(). This
was why I had initially made the length method be protected instead of packaged
private: so that subclasses could be created outside of the o.a.l.store
package. I'd like to just change isFDValid() to be protected. If I do that it
will be visible to subclasses and the package, but not publicly available,
sound OK?
protected is the wrong access flag. Protected should only be used for methods
that should be overridded in subclasses, but never called from outside! I would
make the isFDValid() method public to be consistent and mark it as
@lucene.internal in javadocs.
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
> Key: LUCENE-4848
> URL: https://issues.apache.org/jira/browse/LUCENE-4848
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Michael Poindexter
> Assignee: Uwe Schindler
> Priority: Minor
> Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch,
> LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on
> JDK7). These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue. I'll be happy to make any
> changes requested. I've included some minimal smoke tests, but any help in
> how to use the normal Lucene tests to perform more thorough testing would be
> appreciated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
