[
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607526#comment-13607526
]
Uwe Schindler commented on LUCENE-4848:
---------------------------------------
Robert I know those flags, my complaint was *not* that its not working or
inconsistent. The problem with using protected is that its used in a "logically
inconsistent way". In common Java usage, methods are made protected if they are
implementations to be implemented in subclasses of a general contract that is
only called from the (e.g. final) code in the superclass itsself. Protected
methods should never-ever called from outside the class. Its just working from
the same package, but thats a well-known design issue in Java (there are tons
of blogs about that).
The protected access flag works around the problem we have, thats true, but it
makes the method "public" (in visibility) and thats my problem. So in any case
it must get a @lucene.internal.
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
> Key: LUCENE-4848
> URL: https://issues.apache.org/jira/browse/LUCENE-4848
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Michael Poindexter
> Assignee: Uwe Schindler
> Priority: Minor
> Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch,
> LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on
> JDK7). These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue. I'll be happy to make any
> changes requested. I've included some minimal smoke tests, but any help in
> how to use the normal Lucene tests to perform more thorough testing would be
> appreciated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
