[ 
https://issues.apache.org/jira/browse/LUCENE-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650160#comment-13650160
 ] 

Adrien Grand commented on LUCENE-4981:
--------------------------------------

Sure I can wait. (Even when committed, the old behavior will still be available 
by using luceneMatchVersion=4.3).

I would like to start marking all our broken components (the offenders in 
TestRandomChains) as deprecated so that people start thinking about ways to 
solve their problems without them, stop getting highlighting bugs and can 
eventually smoothly upgrade to 5.0 when we release it. I already started 
deprecating/fixing some tokenizers / token filters for 4.4 (LUCENE-4955 and 
LUCENE-4963) and would like to get as many of them fixed as possible for the 
next release.
                
> Deprecate PositionFilter
> ------------------------
>
>                 Key: LUCENE-4981
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4981
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4981.patch
>
>
> According to the documentation 
> (http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#solr.PositionFilterFactory),
>  PositionFilter is mainly useful to make query parsers generate boolean 
> queries instead of phrase queries although this problem can be solved at 
> query parsing level instead of analysis level (eg. using 
> QueryParser.setAutoGeneratePhraseQueries).
> So given that PositionFilter corrupts token graphs (see TestRandomChains), I 
> propose to deprecate it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to