[ https://issues.apache.org/jira/browse/LUCENE-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650195#comment-13650195 ]
Robert Muir commented on LUCENE-4981: ------------------------------------- The Validatingfilter should be the same logic in BaseTokenStreamTestCase:196 I think its in a separate filter because then its applied at each "stage" of the analysis in TestRandomChains so if there is a bug in a complex analysis chain we know the culprit. > Deprecate PositionFilter > ------------------------ > > Key: LUCENE-4981 > URL: https://issues.apache.org/jira/browse/LUCENE-4981 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Attachments: LUCENE-4981.patch > > > According to the documentation > (http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#solr.PositionFilterFactory), > PositionFilter is mainly useful to make query parsers generate boolean > queries instead of phrase queries although this problem can be solved at > query parsing level instead of analysis level (eg. using > QueryParser.setAutoGeneratePhraseQueries). > So given that PositionFilter corrupts token graphs (see TestRandomChains), I > propose to deprecate it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org