[ 
https://issues.apache.org/jira/browse/LUCENE-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650191#comment-13650191
 ] 

Robert Muir commented on LUCENE-4981:
-------------------------------------

{quote}
which is what made me wonder what about the nature of brokenness: why are 
offsets a problem?
{quote}

I think Adrien describes it correctly: afaik it doesn't do anything super-evil 
like make start offsets go backwards or anything, but it breaks those 
invariants Adrien describes which can cause a follow-on-filter (e.g. shingle) 
to cause further craziness, e.g. things going backwards or endOffset < 
startOffset or other problems.
                
> Deprecate PositionFilter
> ------------------------
>
>                 Key: LUCENE-4981
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4981
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4981.patch
>
>
> According to the documentation 
> (http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#solr.PositionFilterFactory),
>  PositionFilter is mainly useful to make query parsers generate boolean 
> queries instead of phrase queries although this problem can be solved at 
> query parsing level instead of analysis level (eg. using 
> QueryParser.setAutoGeneratePhraseQueries).
> So given that PositionFilter corrupts token graphs (see TestRandomChains), I 
> propose to deprecate it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to