[ 
https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680907#comment-13680907
 ] 

Mark Miller commented on SOLR-4919:
-----------------------------------

Shouldn't we just require setting the parser/writer in the constructor?

I'm not sure I like this setter methods that only work under certain conditions 
- it seems much cleaner to require those in the constructor.

I think we should change that, but as it is, the access of aliveServers.size 
should really be wrapped in a synchronized(aliveServers) block.
                
> Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
> ------------------------------------------------------------------
>
>                 Key: SOLR-4919
>                 URL: https://issues.apache.org/jira/browse/SOLR-4919
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 4.3
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, 
> SOLR-4919.patch
>
>
> Patch to allow setting parser/writer on LBHttpSolrServer.  Will only work if 
> no server objects exist within.  Part of larger issue SOLR-4715.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to