[ 
https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681219#comment-13681219
 ] 

Mark Miller commented on SOLR-4919:
-----------------------------------

bq. A constructor-based patch hits both LBHttpSolrServer and HttpSolrServer. 

What's wrong with that?

Setters that can only be called in some situations without throwing an 
exception are pretty ugly little guys - this seems exactly what a construtor is 
for - what's the motivation for introducing these odd settlers?
                
> Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
> ------------------------------------------------------------------
>
>                 Key: SOLR-4919
>                 URL: https://issues.apache.org/jira/browse/SOLR-4919
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 4.3
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, 
> SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch, 
> SolrExampleJettyTest-testfail.txt, TestReplicationHandler-testfail.txt
>
>
> Patch to allow setting parser/writer on LBHttpSolrServer.  Will only work if 
> no server objects exist within.  Part of larger issue SOLR-4715.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to