[
https://issues.apache.org/jira/browse/SOLR-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681296#comment-13681296
]
Shawn Heisey commented on SOLR-4919:
------------------------------------
I don't think there's anything wrong with changing both objects, except that it
seems to cause the intermittent test failures. I can't tell whether my changes
are the direct cause or whether they have revealed real bugs, but I do believe
that my changes led to the failures. If anyone has any insight into the
attached failures, please let me know.
I took the setter approach initially because I was just trying to duplicate
existing HttpSolrServer functionality. Now that I've been digging around for a
while, I see why that approach wasn't taken from the beginning.
Right now I am hoping to get something in quickly so [~joel.bernstein] can
improve CloudSolrServer on SOLR-4816 without needing to internally extend
LBHttpSolrServer. The setter approach seems to do that, although now that I
think about it, I would need to create a test to make sure.
> Allow setting ResponseParser and RequestWriter on LBHttpSolrServer
> ------------------------------------------------------------------
>
> Key: SOLR-4919
> URL: https://issues.apache.org/jira/browse/SOLR-4919
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 4.3
> Reporter: Shawn Heisey
> Assignee: Shawn Heisey
> Priority: Minor
> Fix For: 5.0, 4.4
>
> Attachments: SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch,
> SOLR-4919.patch, SOLR-4919.patch, SOLR-4919.patch,
> SolrExampleJettyTest-testfail.txt, TestReplicationHandler-testfail.txt
>
>
> Patch to allow setting parser/writer on LBHttpSolrServer. Will only work if
> no server objects exist within. Part of larger issue SOLR-4715.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
