[ 
https://issues.apache.org/jira/browse/LUCENE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690345#comment-13690345
 ] 

Uwe Schindler commented on LUCENE-5070:
---------------------------------------

In LUCENE-2374 it was descided to remove the requirement of equals/hashcode by 
removing the abstarct equals/hashcode. This is somehow the opposite.

Why do you need equals/hashcode. There is no reason to have it. We did not 
remove equals/hashcode from the "well-known" attributes for backwards 
compatibility, but the idea was to not make AttributeSource use equals/hashcode 
at all (so AttributeSource's equals/hashcode impl is a relict from earlier days 
of Lucene 2.9 to Lucene 3.0). 3.1 already relaxed that requirement.
                
> NumericTermAttributeImpl should implement equals
> ------------------------------------------------
>
>                 Key: LUCENE-5070
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5070
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Minor
>
> NumericTermAttributeImpl doesn't implements equals, making two 
> AttributeSources unequal as soon as one of them contains a 
> NumericTermAttributeImpl. I think we should review all our AttributeImpls to 
> make sure they correctly implement equals.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to