[ 
https://issues.apache.org/jira/browse/LUCENE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690382#comment-13690382
 ] 

Adrien Grand commented on LUCENE-5070:
--------------------------------------

bq. complexity for attribute implementors

I agree, hashCode and equals are quite complex (and painful) to implement. I 
guess the only attribute that must implement equals is CharTermAttribute since 
it extends CharSequence.

bq. We can discuss again

If people want to discuss it, I'm open although I'm perfectly fine with the 
current state (not forcing attributes to implement equals).
                
> NumericTermAttributeImpl should implement equals
> ------------------------------------------------
>
>                 Key: LUCENE-5070
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5070
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Minor
>
> NumericTermAttributeImpl doesn't implements equals, making two 
> AttributeSources unequal as soon as one of them contains a 
> NumericTermAttributeImpl. I think we should review all our AttributeImpls to 
> make sure they correctly implement equals.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to