[
https://issues.apache.org/jira/browse/LUCENE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690370#comment-13690370
]
Uwe Schindler commented on LUCENE-5070:
---------------------------------------
I have no preference, but I agree that the current impl of
AttributeSource#equals makes the user think it could compare attribute sources.
We can discuss again, it was just removed for 3.1 because of complexity for
attribute implementors (its often not easy to compare attributes if the
underlying impl implements more than one attribute). The second thing is: The
interface itsself does not have equals/hashcode so there is nothing that
enforces the impl. If a *Impl class implement equals/hashcode it is an
implementation detail.
> NumericTermAttributeImpl should implement equals
> ------------------------------------------------
>
> Key: LUCENE-5070
> URL: https://issues.apache.org/jira/browse/LUCENE-5070
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Priority: Minor
>
> NumericTermAttributeImpl doesn't implements equals, making two
> AttributeSources unequal as soon as one of them contains a
> NumericTermAttributeImpl. I think we should review all our AttributeImpls to
> make sure they correctly implement equals.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
