[ 
https://issues.apache.org/jira/browse/SOLR-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700259#comment-13700259
 ] 

Uwe Schindler commented on SOLR-4916:
-------------------------------------

I don't think this solution is very nice unless we have the "conf" really 
working. Currently all JARs are copied to lib folder ignoring the conf="..." 
attribute and we have to filter them ourselves (see your patch where you 
exclude from WAR file).

In this case (without ivy:cachepatch/ivy:cachefileset) I would prefer the 
current solution.

IMHO, the problem with the release smoker is more the fact that it "checks too 
much". The smoke tester should only deny javax classes in official lib folders 
and JAR files, not in test dependencies. I have really no problem with having 
the test dependencies in Solr's test-framework, of course not in Lucene's 
test-framework. In other lib dir we also have transient non-compile time 
dependencies.

My best idea would be to add a second lib folder (test-framework/runtime-libs) 
that is not packed into the binary ZIP file distribution. It's easy to add: We 
can add a separate resolve with another target folder. In Maven it should also 
definitely not be listed as dependency for runtime, too!
                
> Add support to write and read Solr index files and transaction log files to 
> and from HDFS.
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4916
>                 URL: https://issues.apache.org/jira/browse/SOLR-4916
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4916-ivy.patch, SOLR-4916.patch, SOLR-4916.patch, 
> SOLR-4916.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to