[ 
https://issues.apache.org/jira/browse/SOLR-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700704#comment-13700704
 ] 

Steve Rowe commented on SOLR-4916:
----------------------------------

{quote}
I guess the main use case is for downstream projects to have the ability to 
filter out these dependencies and avoid pulling down the test time dependencies 
- but it seems we would care about that in the maven shadow build, not here - 
we don't publish based on the ivy files right?

In that case, it would seem we should simply do the same thing as with some of 
the other jars in core that are excluded from the webapp - exclude them in the 
build.xml and have the maven build treat them as part of a test configuration?

Steve Rowe, does any of that make any sense?
{quote}

Yes, it does - if these deps were moved to solr-core and declared in the maven 
conf as test scope, they would not be pulled in as transitive deps by consumers 
of the solr-core artifact.

bq. My best idea would be to add a second lib folder 
(test-framework/runtime-libs) that is not packed into the binary ZIP file 
distribution. It's easy to add: We can add a separate resolve with another 
target folder. In Maven it should also definitely not be listed as dependency 
for runtime, too!

If we leave the deps where they are now, on test-framework (which I don't think 
we should do, since these are really only solr-core deps), then they could be 
declared optional in the maven conf, but then all consumers that need these 
deps would need to declare them; so, at least in the maven config, there is 
zero point in keeping them as deps of test-framework.

My vote is to move the deps to solr-core.
                
> Add support to write and read Solr index files and transaction log files to 
> and from HDFS.
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4916
>                 URL: https://issues.apache.org/jira/browse/SOLR-4916
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4916-ivy.patch, SOLR-4916.patch, SOLR-4916.patch, 
> SOLR-4916.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to