[
https://issues.apache.org/jira/browse/LUCENE-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767441#comment-13767441
]
Uwe Schindler commented on LUCENE-5210:
---------------------------------------
I while ago I was also discussing with Dawid and Robert about the
LicenseChecker in general. At the time it was written, we had not yet
experience with using scripting inside ANT.
We should maybe discover removing the java code completely and create the
license checker as a macro like the svn working copy checks. We already have
the framework in common-buil.xml to load the groovy scripting engine, porting
over the java code to be a macro should be very simple (it is mostly copy/paste
and some ANT magic). We can then also test the checker with Antunit, if we
like. The simplicity of this checker does not rectify having the
compile/classpath/ANT overhead. A simple "resolve-grovy" and a macro should do
the work.
Can we keep this issue open for a while until I am back so I can check?
About your patch: To me the patch looks a little bit incorrect regarding
resources: It creates a src/resources folder, which is per convention only for
resources shipped with the JAR file. Test resources are currently next to the
Test .java files. This is not an issue for the tool, because we dont package
them as JAR file, but its still wrong, because the resources are available to
the ANT task when its running "in production".
> Unit tests for LicenseCheckTask.
> --------------------------------
>
> Key: LUCENE-5210
> URL: https://issues.apache.org/jira/browse/LUCENE-5210
> Project: Lucene - Core
> Issue Type: Test
> Components: general/build
> Reporter: Mark Miller
> Attachments: LUCENE-5210.patch, LUCENE-5210.patch
>
>
> While working on LUCENE-5209, I noticed the LicenseCheckTask is kind of a
> second class citizen - excluded from UI src folder setup and with no units
> tests. This was a little scary to me.
> I've started adding some units tests. So far I have mainly just done the
> lifting of getting units tests to work as part of tools.
> I have added two super simple tests - really just the start - but something
> to build on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
