[
https://issues.apache.org/jira/browse/LUCENE-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767475#comment-13767475
]
Mark Miller commented on LUCENE-5210:
-------------------------------------
bq. In addition: I disagree with adding the LicenseCheckTask (and all tools
folders around Lucene) to Eclipse setup. With a good antunit test this is also
not needed.
How is that? When it's not in the eclipse setup, editing the code is annoying
and hard - when it is, it is easy. Does antunit make it nice to edit the code?
I'm not sure how it could.
In any case, thanks for the tip.
bq. We should maybe discover removing the java code completely and create the
license checker as a macro like the svn working copy checks.
Personally, I think doing anything in ant over java is a terrible idea. Ant is
terrible when it's complicated and more and more of us have to be experts in it
to do anything. Ant is so obtuse for anything that is not super straightfoward.
Mixing in Groovy as well really makes my stomach turn :)
bq. To me the patch looks a little bit incorrect regarding resources
I'm not sure that matters, but it can just be a test resources folder as I
intended instead.
Basically, I think being anal about what we end up with should be a clear step
2. Having *any* testing at all for our license checker should be the clear step
one. Once we have any testing, it will make me sad if you make it all ant and
really hard for anyone else to figure out, but I don't really care too much as
long as our very important LiceneCheckTask has tests - right now it's flying
blind.
> Unit tests for LicenseCheckTask.
> --------------------------------
>
> Key: LUCENE-5210
> URL: https://issues.apache.org/jira/browse/LUCENE-5210
> Project: Lucene - Core
> Issue Type: Test
> Components: general/build
> Reporter: Mark Miller
> Attachments: LUCENE-5210.patch, LUCENE-5210.patch
>
>
> While working on LUCENE-5209, I noticed the LicenseCheckTask is kind of a
> second class citizen - excluded from UI src folder setup and with no units
> tests. This was a little scary to me.
> I've started adding some units tests. So far I have mainly just done the
> lifting of getting units tests to work as part of tools.
> I have added two super simple tests - really just the start - but something
> to build on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
