[
https://issues.apache.org/jira/browse/LUCENE-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768025#comment-13768025
]
Robert Muir commented on LUCENE-5210:
-------------------------------------
As far as current patch, i dont really have a problem with it (any other
simplifications can be done later).
I have only one concern: will this make a lucene-tools module (e.g. packaged in
releases, published in maven?)
It seems like it might, which separately might be a good idea so someone can
use the stuff in this folder in their own project, except a few things would be
off as far as packaging:
* it should probably be restructured, so that various configs used by the build
are in src/resources and put inside its jar file (e.g. forbiddenApis configs
and so on)
* I think this depends on ant, but there is no dependency of ant in the ivy.xml
* it would need maven configuration and so on, added in smoketester, etc.
* there might be other exclusions for tools/ in the build that are not
appropriate, etc.
* as far as the name, maybe build-tools would be a better one (since its not
tools for working on lucene indexes).
If smoketester passes though, I am happy: We can just make sure its excluded
from the right places and not doing something we don't want wrt packaging for
now, and discuss this stuff on other issues.
> Unit tests for LicenseCheckTask.
> --------------------------------
>
> Key: LUCENE-5210
> URL: https://issues.apache.org/jira/browse/LUCENE-5210
> Project: Lucene - Core
> Issue Type: Test
> Components: general/build
> Reporter: Mark Miller
> Attachments: LUCENE-5210.patch, LUCENE-5210.patch
>
>
> While working on LUCENE-5209, I noticed the LicenseCheckTask is kind of a
> second class citizen - excluded from UI src folder setup and with no units
> tests. This was a little scary to me.
> I've started adding some units tests. So far I have mainly just done the
> lifting of getting units tests to work as part of tools.
> I have added two super simple tests - really just the start - but something
> to build on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
