[GitHub] lucenenet pull request: Adding a MergeScheduler that uses Tasks

[synhershko]

Github user synhershko commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/171#discussion_r62450979
  
    --- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
    @@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer, 
LuceneVersion matchVersion)
                 useCompoundFile = 
IndexWriterConfig.DEFAULT_USE_COMPOUND_FILE_SYSTEM;
                 openMode = OpenMode_e.CREATE_OR_APPEND;
                 similarity = IndexSearcher.DefaultSimilarity;
    +#if FEATURE_TASKMERGESCHEDULER
    +            mergeScheduler = new TaskMergeScheduler();
    +#else
                 mergeScheduler = new ConcurrentMergeScheduler();
    +#endif
    --- End diff --
    
    The C# way is to use the object initializer on LiveIndexWriterConfig to set 
it, so:
    
    new LiveIndexWriterConfig() { MergeScheduler = new TaskMergeScheduler() }
    
    while keeping ConcurrentMergeScheduler the default.
    
    WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---