Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62450572
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion matchVersion)
useCompoundFile =
IndexWriterConfig.DEFAULT_USE_COMPOUND_FILE_SYSTEM;
openMode = OpenMode_e.CREATE_OR_APPEND;
similarity = IndexSearcher.DefaultSimilarity;
+#if FEATURE_TASKMERGESCHEDULER
+ mergeScheduler = new TaskMergeScheduler();
+#else
mergeScheduler = new ConcurrentMergeScheduler();
+#endif
--- End diff --
I agree that adding it as a ctor parameter is better. How would you decide
whether to use ConcurrentMergeScheduler or TaskMergeScheduler? Would it be a
config value... or?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
