GitHub user jeme opened a pull request:
https://github.com/apache/lucenenet/pull/209
RFC: LUCENENET-565: Porting of Lucene.Net.Replicator
Commit is for Review with comments about original Java Source for
assistance.
- [ ] RevisionFile.Size - Please change to `Length` to .NETify
- [ ] IReplicator & IRevision: Please leave the "I" prefix in the actual
name of the interfaces, but change the names of the files back to the original
"Replicator" and "Revision". It is easier to maintain if the files are in the
same order as they are in Java.
- [ ] Please change IReadOnlyCollection, IReadOnlyDictionary, etc to
ICollection, IDictionary, etc.
- [ ] Please rename (the class only, not the file) IndexInputInputStream to
IndexInputStream (since in .NET InputStream is just a Stream).
- [ ] Please add the project.json and PROJECTNAME.project.json files to the
projects (we use these for NuGet dependencies as well as for specifying NuGet
package info). See the other projects for examples.
- [ ] Please arrange the code so it is in a similar order as it was in
Java. In cases where you need to order it differently (such as de-nesting
types), add a "LUCENENET specific" comment to indicate it diverges from Java.
- [ ] Please ensure it will compile and tests will pass on .NET Core (we
use the Lucene.Net.Portable.sln file to do these tests).
- [ ] Replace BinaryFormatter with Json
- [ ] Use DataInputStream and DataOutputStream instead of DataInput and
DataOutput.
Note: Missing .NET Core project files because of the current situation with
.NET Core/Standard project files as discussed in
https://issues.apache.org/jira/browse/LUCENENET-565
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeme/lucenenet Lucene.Net.Replicator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/209.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #209
----
commit 6da4dd20d45b152df0c0cf5f4e6c90a8024682e5
Author: jeme <[email protected]>
Date: 2017-07-22T10:52:19Z
LUCENENET-565: Porting of Lucene Replicator - Commit is for Review with
comments about original Java Source for assistance.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
