paulirwin commented on code in PR #981:
URL: https://github.com/apache/lucenenet/pull/981#discussion_r1809521321
##########
src/dotnet/tools/Lucene.Net.Tests.Cli/Lucene.Net.Tests.Cli.csproj:
##########
@@ -25,11 +25,11 @@
<PropertyGroup>
<!-- Allow specific target framework to flow in from
TestTargetFrameworks.props -->
- <TargetFrameworks Condition=" '$(TargetFramework)' == ''
">net8.0;net6.0</TargetFrameworks>
+ <TargetFrameworks Condition=" '$(TargetFramework)' == ''
">net8.0</TargetFrameworks>
<AssemblyTitle>Lucene.Net.Tests.Cli</AssemblyTitle>
</PropertyGroup>
- <PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or
$(TargetFramework.StartsWith('net5.')) ">
+ <PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or
$(TargetFramework.StartsWith('net5.')) Or
$(TargetFramework.StartsWith('net6.')) ">
Review Comment:
Do we need these conditions if it's always just net8.0 above?
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,11 +24,11 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <TargetFrameworks>net8.0</TargetFrameworks>
<RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
<IsPublishable>false</IsPublishable>
- <IsPublishable Condition="'$(TargetFramework)' == 'net8.0' Or
'$(TargetFramework)' == 'net6.0'">true</IsPublishable>
Review Comment:
Do we need these conditions if it's always just net8.0 above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
