NightOwl888 commented on code in PR #981:
URL: https://github.com/apache/lucenenet/pull/981#discussion_r1809570918
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,11 +24,11 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <TargetFrameworks>net8.0</TargetFrameworks>
<RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
<IsPublishable>false</IsPublishable>
- <IsPublishable Condition="'$(TargetFramework)' == 'net8.0' Or
'$(TargetFramework)' == 'net6.0'">true</IsPublishable>
Review Comment:
No. This is just a quirk because we have some projects that target fewer
and/or different targets than the "standard" set. So, the logic that we use is:
1. In CI, publish only the targets that are supported
2. In the IDE, allow the `TestTargetFrameworks.props` file to either run all
targets or some of them.
Then the individual `.csproj` handle these special cases. The IDE needs
something there for the selected target or it breaks (in some way I don't
recall). The publish also breaks if the `.csproj` cannot handle one of the
solution-level targets that is passed in. So this is a hack that handles both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
