NightOwl888 commented on code in PR #981:
URL: https://github.com/apache/lucenenet/pull/981#discussion_r1809554968
##########
src/dotnet/tools/Lucene.Net.Tests.Cli/Lucene.Net.Tests.Cli.csproj:
##########
@@ -25,11 +25,11 @@
<PropertyGroup>
<!-- Allow specific target framework to flow in from
TestTargetFrameworks.props -->
- <TargetFrameworks Condition=" '$(TargetFramework)' == ''
">net8.0;net6.0</TargetFrameworks>
+ <TargetFrameworks Condition=" '$(TargetFramework)' == ''
">net8.0</TargetFrameworks>
<AssemblyTitle>Lucene.Net.Tests.Cli</AssemblyTitle>
</PropertyGroup>
- <PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or
$(TargetFramework.StartsWith('net5.')) ">
+ <PropertyGroup Condition=" $(TargetFramework.StartsWith('net4')) Or
$(TargetFramework.StartsWith('net5.')) Or
$(TargetFramework.StartsWith('net6.')) ">
Review Comment:
In this case, `TestTargetFramework.props` takes priority over what is
defined here *if* it is set to `TargetFrameworks`, which we do in CI. If it is
a specific `TargetFramework` (which is what we normally do in the IDE), then we
will either respect it or patch it up so there is a valid configuration in the
IDE, since the IDE doesn't understand a test project with no targets in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
