NightOwl888 commented on code in PR #1005: URL: https://github.com/apache/lucenenet/pull/1005#discussion_r1823397107
########## websites/site/.htaccess: ########## @@ -32,13 +32,14 @@ # version, with [R=301] signaling permanent redirects and [L] preventing further # rule processing. # -# Note: This file is line ending sensitive. MUST use LF line endings. +# Note: This file is line ending and BOM sensitive. It MUST use LF line endings and +# MUST NOT have a BOM. RewriteEngine On # Redirect /docs/latest/ to /docs/3.0.3/ RewriteRule ^docs/latest/(.*)$ /docs/3.0.3/$1 [R=301,L] -# Redirect /docs/absolute-latest/ to /docs/4.8.0-beta00016/ -RewriteRule ^docs/absolute-latest/(.*)$ /docs/4.8.0-beta00016/$1 [R=301,L] +# Redirect /docs/absolute-latest/ to /docs/4.8.0-beta00017/ +RewriteRule ^docs/absolute-latest/(.*)$ /docs/4.8.0-beta00017/$1 [R=301,L] Review Comment: Yeah. But, actually it probably would be better to automate it (if we can get the file format right). docs.ps1 already does some replacements based on regex. However, the approach used always adds a line to the end of the file. We probably should find a solution to that if we do it. But I don't feel strongly whether we do the automation or put it into the checklist so it is done when we release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
