NightOwl888 commented on code in PR #1005: URL: https://github.com/apache/lucenenet/pull/1005#discussion_r1831341894
########## websites/site/.htaccess: ########## @@ -32,13 +32,14 @@ # version, with [R=301] signaling permanent redirects and [L] preventing further # rule processing. # -# Note: This file is line ending sensitive. MUST use LF line endings. +# Note: This file is line ending and BOM sensitive. It MUST use LF line endings and +# MUST NOT have a BOM. RewriteEngine On # Redirect /docs/latest/ to /docs/3.0.3/ RewriteRule ^docs/latest/(.*)$ /docs/3.0.3/$1 [R=301,L] -# Redirect /docs/absolute-latest/ to /docs/4.8.0-beta00016/ -RewriteRule ^docs/absolute-latest/(.*)$ /docs/4.8.0-beta00016/$1 [R=301,L] +# Redirect /docs/absolute-latest/ to /docs/4.8.0-beta00017/ +RewriteRule ^docs/absolute-latest/(.*)$ /docs/4.8.0-beta00017/$1 [R=301,L] Review Comment: I reread your proposal and I do think your idea could work. So, if you would like to work on the automation, that would be great. I don't see how it makes any difference whether we use docfx or Powershell to do the copy, though. Note that when something is pushed to master, it is expected to be in a buildable state. Having non-functional automation blocks others from doing work. The Powershell approach failed for the second time when I was attempting to deploy the website. The first time it was because the _site directory didn't exist (which I fixed in Powershell by creating the directory if it doesn't exist). I am not sure what the issue was this time, but it was definitely broken and giving the same error message that the path to `.htaccess` was invalid (and it definitely didn't break because of this PR). This was blocking me from finishing #1011, which required a site deployment, so I unblocked it by using docfx to copy the files. This is the same approach that was done for other files that are copied to the root of the website. I was in the process of updating the release procedure anyway and it seemed easier to add the manual instructions to update the file than to wait for automation. Technically, all of that manual work in the release procedure is up for grabs for automation. But the release notes were the most laborious part of a release, so I found a way to automate them. I didn't realize I had missed your reply last week until I had all of the work completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
