NightOwl888 commented on code in PR #1005: URL: https://github.com/apache/lucenenet/pull/1005#discussion_r1830804853
########## websites/site/.htaccess: ########## @@ -32,13 +32,14 @@ # version, with [R=301] signaling permanent redirects and [L] preventing further # rule processing. # -# Note: This file is line ending sensitive. MUST use LF line endings. +# Note: This file is line ending and BOM sensitive. It MUST use LF line endings and +# MUST NOT have a BOM. RewriteEngine On # Redirect /docs/latest/ to /docs/3.0.3/ RewriteRule ^docs/latest/(.*)$ /docs/3.0.3/$1 [R=301,L] -# Redirect /docs/absolute-latest/ to /docs/4.8.0-beta00016/ -RewriteRule ^docs/absolute-latest/(.*)$ /docs/4.8.0-beta00016/$1 [R=301,L] +# Redirect /docs/absolute-latest/ to /docs/4.8.0-beta00017/ +RewriteRule ^docs/absolute-latest/(.*)$ /docs/4.8.0-beta00017/$1 [R=301,L] Review Comment: Yeah, this seems to be a hard problem. Ideally, the docs would be built as part of the deployment pipeline where the PackageVersion is available, but currently that is all manual except for the NuGet push. I updated the procedure in: https://github.com/apache/lucenenet/pull/1010 so this can be dealt with manually for the time being. It definitely needs to be part of the checklist, or we risk skipping it during a release. The website also failed to build again because the Powershell copy failed again (not sure why this time, I previously added the script to create the directory if it doesn't exist). Since this is so troublesome, I added the `.htaccess` and `.gitattributes` files to the `docfx.json` file as resources so they would get copied by docfx during the build rather than relying on Powershell to do it. We already were doing this for the DOAP file. I will also cherry-pick this commit along with mine to the `docs/4.8.0-beta00017` branch, which is where we are supposed to be building the website and docs from (since that branch freezes the API at 4.8.0-beta00017). We definitely don't want to merge master into that branch again, though. Although it is fine to merge it into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
