paulirwin commented on code in PR #1018:
URL: https://github.com/apache/lucenenet/pull/1018#discussion_r1842562419
##########
src/Lucene.Net.Tests/Codecs/Compressing/TestCompressingStoredFieldsFormat.cs:
##########
@@ -35,6 +35,7 @@ namespace Lucene.Net.Codecs.Compressing
using MockAnalyzer = Lucene.Net.Analysis.MockAnalyzer;
using RandomIndexWriter = Lucene.Net.Index.RandomIndexWriter;
+ // LUCENENET: Moved @Repeat(iterations=5) to the method level
Review Comment:
RepeatAttribute does not work at the class level 😄 And note that there is
not really a "moving back" because it wasn't here in Lucene.NET previously at
time of review.
> Attribute 'NUnit.Framework.RepeatAttribute' is not valid on this
declaration type. It is valid on 'Method' declarations only.
And I do not think we should include those in a base class as a general
case. The tests could be overridden if necessary to add the repeat attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
