paulirwin commented on code in PR #1018: URL: https://github.com/apache/lucenenet/pull/1018#discussion_r1844083009
########## src/Lucene.Net.Tests/Document/TestBinaryDocument.cs: ########## @@ -95,24 +89,35 @@ public virtual void TestCompressionTools() IIndexableField binaryFldCompressed = new StoredField("binaryCompressed", CompressionTools.Compress(binaryValCompressed.GetBytes(Encoding.UTF8))); IIndexableField stringFldCompressed = new StoredField("stringCompressed", CompressionTools.CompressString(binaryValCompressed)); - var doc = new Documents.Document {binaryFldCompressed, stringFldCompressed}; + var doc = new Document(); Review Comment: Reverted; but note that there are _a ton_ of places where we're not doing this, so I had originally changed it to use `.Add` to match the multitude of places where we're doing that. I think we could use some LUCENENET-specific tests for this if we were concerned, but the collection initializer just calls `.Add` anyways, so I'm not particularly concerned about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org