paulirwin commented on code in PR #1018: URL: https://github.com/apache/lucenenet/pull/1018#discussion_r1844123408
########## src/Lucene.Net.Tests/Codecs/Lucene40/TestLucene40PostingsReader.cs: ########## @@ -44,16 +44,14 @@ namespace Lucene.Net.Codecs.Lucene40 [TestFixture] public class TestLucene40PostingsReader : LuceneTestCase { - internal static readonly string[] terms = LoadTerms(); + internal static readonly string[] terms = new string[100]; - static string[] LoadTerms() + static TestLucene40PostingsReader() Review Comment: No one should be using this test code in production (per the original reasoning), but I'll change it. This shows the importance of leaving comments when the code deviates from upstream (as was missing here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org