paulirwin commented on PR #1170: URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233700545
Alternatively, we could make the serialize methods internal and go ahead and accept a breaking change that they're not supposed to be part of our public API? It seems to me like this type is intended to be somewhat opaque anyways, and arguably it's a SRP violation to have serialization inside of it. Just a thought. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
