NightOwl888 commented on PR #1170: URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233823824
> Alternatively, we could make the serialize methods internal and go ahead and accept a breaking change that they're not supposed to be part of our public API? It seems to me like this type is intended to be somewhat opaque anyways, and arguably it's a SRP violation to have serialization inside of it. Just a thought. Good point. Since `SerializeAsync()` is a brand new method, we can mark it `internal` until we have it finalized. `PerformAsync()` is the public method that gets called by the hosted network service, so it isn't likely something that `Lucene.Net.Extensions` will need. And if so, there is always `InternalsVisibleTo`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
