NightOwl888 commented on PR #1170: URL: https://github.com/apache/lucenenet/pull/1170#issuecomment-3233676532
> This is currently mostly blocking our GSoC work from wrapping up, so I'd prefer to accept the allocations for now and do a fast-follow item for the pipelines. Assuming that it won't change the API contract either for the replicator interfaces/classes or the across-the-wire data format. It changes the API contract on `SessionToken` ```c# public async Task SerializeAsync(Stream output, CancellationToken cancellationToken = default) ``` to ```c# public async Task SerializeAsync(PipeWriter writer, CancellationToken cancellationToken = default) ``` Not sure whether that is a deal breaker, though. This method is public, but called by `PerformAsync()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@lucenenet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
