[
https://issues.apache.org/jira/browse/MAHOUT-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006404#comment-13006404
]
Sean Owen commented on MAHOUT-586:
----------------------------------
Before I look at it in detail --
* (The patch is misnamed but no big deal -- it just helps JIRA)
* A lot of the line changes are whitespace changes, or formatting changes that
are not obviously "fixes". Can these be filtered? I think it's obscuring the
real changes.
* The auto-generated "non-Javadoc" comments aren't useful and should be removed.
* Same for "TODO auto-generated stub" comments.
* You might have a glance over it for style... some stuff doesn't quite match
the surrounding code in small ways (e.g. braces on newlines)
I don't yet have a full understanding of the patch, admittedly. But the spirit
of my last comment is that I think it's desirable to keep the current API,
unless it's broken, and I don't think it's broken. The patch appears to do a
fair bit of re-constructing the existing API in a different way. I'd hope to
see more extending than replacing.
> Redo RecommenderEvaluator for modularity
> ----------------------------------------
>
> Key: MAHOUT-586
> URL: https://issues.apache.org/jira/browse/MAHOUT-586
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Reporter: Lance Norskog
> Assignee: Sean Owen
> Fix For: 0.5
>
> Attachments: MAHOUT-559.patch, MAHOUT-586.patch
>
>
> The RecommenderEvaluator implementation is hard-coded around one algorithm.
> This is a more flexible, modular rewrite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
