You mean other than a web UI to see the patch, without having to download it, make sure you have a clean checkout to apply it to, then fire it up in your IDE, again making sure you have actually caught all the diffs?
But yes, threaded comments inline with the code and the ability to easily show differences between patch versions lead to this workflow: patch uploaded, review created. People point out problems line by line, the original poster (or someone else) replies in-line, corrects the patch, uploads it again, and the reviewers can click the "show diffs of patch 2 relative to patch 1", and very quickly see their concerns were taken care of, click "ship-it", and its good to go. Once you get in the rhythm of it, it leads to far more careful reviewing by more eyeballs, IMO. We use it religously at Twitter. -jake On Dec 13, 2011 8:50 AM, "Dmitriy Lyubimov" <[email protected]> wrote: I guess the fact that you can select a code fragment you are commenting on. But I haven't yet fully learned how to use it. On Dec 13, 2011 8:41 AM, "Grant Ingersoll" <[email protected]> wrote: > What benefit does the rev...
