I will say I like the inline comments On Dec 13, 2011, at 1:41 PM, Grant Ingersoll wrote:
> > On Dec 13, 2011, at 12:44 PM, Jake Mannix wrote: > >> You mean other than a web UI to see the patch, without having to download >> it, make sure you have a clean checkout to apply it to, then fire it up in >> your IDE, again making sure you have actually caught all the diffs? > > Are you saying it automatically applies the patch and runs the tests? Now > that would be useful! If not, what's the time saving other than for quick, > on the run feedback for superficial things? Otherwise, don't you kind of > have to do those steps anyway to know the tests pass? Or perhaps you have a > compiler + JUnit built into your brain? Because that's the functionality > that takes the most time and once you've done those steps you can just as > well view the diffs in your IDE. > >> >> But yes, threaded comments inline with the code and the ability to easily >> show differences between patch versions lead to this workflow: patch >> uploaded, review created. People point out problems line by line, the >> original poster (or someone else) replies in-line, corrects the patch, >> uploads it again, and the reviewers can click the "show diffs of patch 2 >> relative to patch 1", and very quickly see their concerns were taken care >> of, click "ship-it", and its good to go. > > Does "ship it" then apply and commit the patch? Or do I still have to do all > that stuff above anyway? > > Still skeptical but willing to be convinced, > Grant >
