[
https://issues.apache.org/jira/browse/MAHOUT-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498731#comment-13498731
]
Dan Filimon commented on MAHOUT-1116:
-------------------------------------
I agree that the compareTo() implementation itself is strange in that it also
does the element by element comparison of the vectors.
Perhaps there should be a different issue for the refactoring of the comparator
code.
I think it's fair to decouple the equals() from the compareTo() since that's a
well defined function.
> WeightedVectors do not implement equals()
> -----------------------------------------
>
> Key: MAHOUT-1116
> URL: https://issues.apache.org/jira/browse/MAHOUT-1116
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Affects Versions: 1.0
> Reporter: Dan Filimon
> Priority: Minor
> Labels: newbie
> Attachments: WeightedVector_MAHOUT_1116.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> WeightedVectors [1] implement compareTo but not equals so in cases where just
> the weights or the indices differ, despire compareTo returning 0, equals
> returns false.
> [1]
> https://github.com/apache/mahout/blob/trunk/math/src/main/java/org/apache/mahout/math/WeightedVector.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
