[ 
https://issues.apache.org/jira/browse/MAHOUT-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Owen updated MAHOUT-1116:
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8
         Assignee: Sean Owen
           Status: Resolved  (was: Patch Available)

I committed my patch. I introduced the same constant (though it needs to be 
1e-8 not 10e-8). I don't think can add just equals() to this class and not 
hashCode(). Moving out compareTo() restores it to at least a consistent state.
                
> WeightedVectors do not implement equals()
> -----------------------------------------
>
>                 Key: MAHOUT-1116
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1116
>             Project: Mahout
>          Issue Type: Bug
>          Components: Math
>    Affects Versions: 1.0
>            Reporter: Dan Filimon
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.8
>
>         Attachments: MAHOUT-1116.patch, WeightedVector_MAHOUT_1116.patch, 
> WeightedVector_MAHOUT_1116.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> WeightedVectors [1] implement compareTo but not equals so in cases where just 
> the weights or the indices differ, despire compareTo returning 0, equals 
> returns false.
> [1] 
> https://github.com/apache/mahout/blob/trunk/math/src/main/java/org/apache/mahout/math/WeightedVector.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to