[
https://issues.apache.org/jira/browse/MAHOUT-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498956#comment-13498956
]
Ted Dunning commented on MAHOUT-1116:
-------------------------------------
Breaking out the comparison into a separate Comparator (which can even be a
static class inside WeightedVector) is a grand idea.
Any code that breaks should be easy to fix. Since WV is so new, this should
mostly be confined to the knn code that hasn't made it into Mahout yet.
> WeightedVectors do not implement equals()
> -----------------------------------------
>
> Key: MAHOUT-1116
> URL: https://issues.apache.org/jira/browse/MAHOUT-1116
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Affects Versions: 1.0
> Reporter: Dan Filimon
> Priority: Minor
> Labels: newbie
> Attachments: MAHOUT-1116.patch, WeightedVector_MAHOUT_1116.patch,
> WeightedVector_MAHOUT_1116.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> WeightedVectors [1] implement compareTo but not equals so in cases where just
> the weights or the indices differ, despire compareTo returning 0, equals
> returns false.
> [1]
> https://github.com/apache/mahout/blob/trunk/math/src/main/java/org/apache/mahout/math/WeightedVector.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira