[ 
https://issues.apache.org/jira/browse/MAHOUT-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567553#comment-15567553
 ] 

ASF GitHub Bot commented on MAHOUT-1885:
----------------------------------------

Github user dlyubimov commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/261#discussion_r82933399
  
    --- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/scalabindings/SolverFactory.scala
 ---
    @@ -0,0 +1,71 @@
    +/**
    +  * Licensed to the Apache Software Foundation (ASF) under one or more
    +  * contributor license agreements.  See the NOTICE file distributed with
    +  * this work for additional information regarding copyright ownership.
    +  * The ASF licenses this file to You under the Apache License, Version 2.0
    +  * (the "License"); you may not use this file except in compliance with
    +  * the License.  You may obtain a copy of the License at
    +  *
    +  * http://www.apache.org/licenses/LICENSE-2.0
    +  *
    +  * Unless required by applicable law or agreed to in writing, software
    +  * distributed under the License is distributed on an "AS IS" BASIS,
    +  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +  * See the License for the specific language governing permissions and
    +  * limitations under the License.
    +  */
    +package org.apache.mahout.math.scalabindings
    +
    +import java.io.File
    +
    +import org.apache.mahout.logging._
    +
    +import scala.reflect.ClassTag
    +import scala.reflect.runtime._
    +import scala.reflect._
    +
    +
    +class SolverFactory {
    +
    +  private final implicit val log = getLog(this.getClass)
    +
    +  // just temp for quick POC
    +  val classMap: Map[String,String] =
    +    Map(("GPUMMul"->"org.apache.mahout.viennacl.opencl.GPUMMul"),
    --- End diff --
    
    right, ok, but eventually it is probed and initialized on singleton init 
via (hopefully) a Backend's interface interrogations.
    Typically, there are known (predefined) Backend set of classes + additional 
custom backends via a property. 
    
    The backend concrete implementations do not generally have to be a 
dependency of this module (e.g., because there are no native javacpp codes for 
this platform), so generally there's no concrete dependency and hense class 
name cannot be used directly, only via reflection. 
    
    On the other hand, in order to enable a custom (well-known) backend, it 
should be sufficient to drop in a version of such compiled for current platform 
for things to start moving around. 
    
    Consider, for example, a blas Backend. then solvers there generally would 
not be available if (1) blas backend jar is not in the classpath; or (2) blas 
backend probed -- and reported back as unavailable (usually due to failure to 
bind to libBlas.so in the system).


> Inital Implementation of VCL Bindings
> -------------------------------------
>
>                 Key: MAHOUT-1885
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1885
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>    Affects Versions: 0.12.2
>            Reporter: Andrew Palumbo
>            Assignee: Andrew Palumbo
>             Fix For: 0.13.0
>
>
> Push a working experimental branch of VCL bindings into master.  There is 
> still a lot of work to be done.  All tests are passing, At the moment there 
> am opening this JIRA mostly to get a number for PR and to test profiles 
> against on travis. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to