[ https://issues.apache.org/jira/browse/MAHOUT-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567551#comment-15567551 ]
ASF GitHub Bot commented on MAHOUT-1885: ---------------------------------------- Github user dlyubimov commented on a diff in the pull request: https://github.com/apache/mahout/pull/261#discussion_r82932910 --- Diff: math-scala/src/main/scala/org/apache/mahout/math/scalabindings/RLikeMatrixOps.scala --- @@ -17,14 +17,22 @@ package org.apache.mahout.math.scalabindings import org.apache.mahout.math.function.Functions -import org.apache.mahout.math.{Vector, Matrix} +import org.apache.mahout.math.{Matrix, Vector} import scala.collection.JavaConversions._ import RLikeOps._ +import org.apache.mahout.math.scalabindings._ + class RLikeMatrixOps(m: Matrix) extends MatrixOps(m) { /** Structure-optimized mmul */ - def %*%(that: Matrix) = MMul(m, that, None) + + implicit var solverOperator: opMMulSolver =_ --- End diff -- Somehow i don't like implicit vars inside the decorator pattern. Clean decorator pattern (which is what it really is) assumes there's no new intrinsic state. so the only value instrinsic is `m`. Instead, it should query solvers from a table as instantiated and saved in the current solver factory. > Inital Implementation of VCL Bindings > ------------------------------------- > > Key: MAHOUT-1885 > URL: https://issues.apache.org/jira/browse/MAHOUT-1885 > Project: Mahout > Issue Type: Improvement > Components: Math > Affects Versions: 0.12.2 > Reporter: Andrew Palumbo > Assignee: Andrew Palumbo > Fix For: 0.13.0 > > > Push a working experimental branch of VCL bindings into master. There is > still a lot of work to be done. All tests are passing, At the moment there > am opening this JIRA mostly to get a number for PR and to test profiles > against on travis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)