[ https://issues.apache.org/jira/browse/MAHOUT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830723#comment-15830723 ]
ASF GitHub Bot commented on MAHOUT-1856: ---------------------------------------- Github user dlyubimov commented on a diff in the pull request: https://github.com/apache/mahout/pull/246#discussion_r96467982 --- Diff: math-scala/src/main/scala/org/apache/mahout/math/algorithms/Model.scala --- @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.mahout.math.algorithms + +import org.apache.mahout.math.{Vector => MahoutVector, drm} +import org.apache.mahout.math.drm.DrmLike +import org.apache.mahout.math.scalabindings._ + +import scala.reflect.ClassTag + +abstract class Model extends Serializable { + + var fitParams = collection.mutable.Map[String, MahoutVector]() --- End diff -- So model requires all parameters be named and be vectors? Shouldn't this be an artifact of a more specialized models, like say glms? there are plenty of ML models that would probably not fit that fairly rigid definition, not easily or pragmatically, at least. > Create a framework for new Mahout Clustering, Classification, and > Optimization Algorithms > ------------------------------------------------------------------------------------------ > > Key: MAHOUT-1856 > URL: https://issues.apache.org/jira/browse/MAHOUT-1856 > Project: Mahout > Issue Type: New Feature > Affects Versions: 0.12.1 > Reporter: Andrew Palumbo > Assignee: Trevor Grant > Priority: Critical > Fix For: 0.13.0 > > > To ensure that Mahout does not become "A loose bag of algorithms", Create > basic traits with funtions common to each class of algorithm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)