[ 
https://issues.apache.org/jira/browse/MAHOUT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833728#comment-15833728
 ] 

ASF GitHub Bot commented on MAHOUT-1856:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/246#discussion_r97235841
  
    --- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/AutocorrelationTests.scala
 ---
    @@ -0,0 +1,54 @@
    +/**
    +  * Licensed to the Apache Software Foundation (ASF) under one
    +  * or more contributor license agreements. See the NOTICE file
    +  * distributed with this work for additional information
    +  * regarding copyright ownership. The ASF licenses this file
    +  * to you under the Apache License, Version 2.0 (the
    +  * "License"); you may not use this file except in compliance
    +  * with the License. You may obtain a copy of the License at
    +  *
    +  * http://www.apache.org/licenses/LICENSE-2.0
    +  *
    +  * Unless required by applicable law or agreed to in writing,
    +  * software distributed under the License is distributed on an
    +  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +  * KIND, either express or implied. See the License for the
    +  * specific language governing permissions and limitations
    +  * under the License.
    +  */
    +
    +package org.apache.mahout.math.algorithms.regression.tests
    +
    +import org.apache.mahout.math.algorithms.regression.Regressor
    +import org.apache.mahout.math.drm.DrmLike
    +import org.apache.mahout.math.drm.RLikeDrmOps._
    +import org.apache.mahout.math.function.Functions.SQUARE
    +import org.apache.mahout.math.scalabindings.RLikeOps._
    +
    +
    +object AutocorrelationTests {
    +
    +  //https://en.wikipedia.org/wiki/Durbin%E2%80%93Watson_statistic
    +  /*
    +  To test for positive autocorrelation at significance α, the test 
statistic d is compared to lower and upper critical values (dL,α and dU,α):
    +      If d < dL,α, there is statistical evidence that the error terms are 
positively autocorrelated.
    +      If d > dU,α, there is no statistical evidence that the error terms 
are positively autocorrelated.
    +      If dL,α < d < dU,α, the test is inconclusive.
    +
    +      Rule of Thumb:
    +       d < 2 : positive auto-correlation
    +       d = 2 : no auto-correlation
    +       d > 2 : negative auto-correlation
    +  */
    +  def DurbinWaton[K](model: Regressor[K]): Regressor[K] = {
    --- End diff --
    
    misspelling- "DurbinWatson" 


> Create a framework for new Mahout Clustering, Classification, and 
> Optimization  Algorithms
> ------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-1856
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1856
>             Project: Mahout
>          Issue Type: New Feature
>    Affects Versions: 0.12.1
>            Reporter: Andrew Palumbo
>            Assignee: Trevor Grant
>            Priority: Critical
>             Fix For: 0.13.0
>
>
> To ensure that Mahout does not become "A loose bag of algorithms", Create 
> basic traits with funtions common to each class of algorithm. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to