[
https://issues.apache.org/jira/browse/CONNECTORS-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638061#comment-13638061
]
Karl Wright commented on CONNECTORS-676:
----------------------------------------
Ok, I committed changes to the branch which fix a number of problems, as
follows:
(a) pom references should use our parent-defined version numbers
(b) ant build needed completion
(c) Missing apache headers in some files
(d) Apache formatting standard is 2 spaces per indent, not 4
(e) Thread structure had some threads that were not needed, and was missing
threads that were needed
(f) License needed to mention the dependent jars
(g) Exception handling was incorrect and incomplete
The threading changes could potentially break things so it would be good to try
this out. If you have a dropbox account, it would be great if you could
confirm that everything still works - preferably with the ant build. You are
certainly more familiar with dropbox than I am.
Remaining questions:
(1) Path parameter seems both required and not real (at least in the UI it says
it is not used). Can you clarify your intention here? I would not want to
include this connector in an unfinished state.
(2) The cursor in DropboxSession seems to be persistent for the session, which
I am not sure is a good idea. Can you clarify what your intention is here?
(3) It would be good to characterize dropbox exceptions in more detail than I
have at this point. ManifoldCF basically makes you decide which exceptions are
"permanent" and which are "transient". Of the transient ones, some should be
retried for a time and then either the document should be skipped or the job
should be aborted. We need to know the decision matrix for these exceptions in
order to make the connector do the right thing in all cases.
> Connector for dropbox
> ---------------------
>
> Key: CONNECTORS-676
> URL: https://issues.apache.org/jira/browse/CONNECTORS-676
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Dropbox connector
> Affects Versions: ManifoldCF 1.1.1
> Reporter: Andrew Janowczyk
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.2
>
> Attachments: dropbox-patch.patch
>
>
> Pretty straight forward. It'd be nice to have a connector which can read from
> dropbox.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
