[
https://issues.apache.org/jira/browse/CONNECTORS-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638389#comment-13638389
]
Karl Wright commented on CONNECTORS-676:
----------------------------------------
bq. i used the CMIS connector code as a starting point so all the threading
should be exactly the same as in there.
The only time you want to spin up a thread is when there's a chance that the
operation you are doing will wait on a socket. In java post 1.4 this
unfortunately is uninterruptible, and thus it would block the agents process
from shutting down promptly.
bq. my plan is to use the path Parameter as a filter to say "i only want to
index things in this directory of my dropbox" but i'm not sure if that is
better or not.
It probably is better, but there's no way to know if it is needed or not.
You'd need a use case to know for sure. Usually a proper implementation of
this kind of thing involves a set of rules, and a "rule builder" (see the
SharePoint connector for an idea what that can wind up looking like). So for
now, given the complexity of adding the feature in the proper way, I'd say
leave it out entirely for now.
bq. Good question about the cursor. dropbox supports delta operations, i.e. you
give it a cursor and it will tell you what files have
changed(added/deleted/modified) since that point in time.
That's great functionality. In the ManifoldCF case, you are given a start time
and an end time. How would you turn that into a Dropbox cursor?
Also, if deletions are also detected, then you should be returning
MODEL_ADD_CHANGE_DELETE, not the default MODEL_ALL. And, finally, how does
this interact with directories? Can you get all FILES with the cursor, even in
subdirectories? If so that is by far preferable to discovering documents a
directory at a time.
bq. they have a list of standard API errors listed here
When one of these errors happens, what DropboxException gets thrown? That's
not clear at all, AFAICT.
bq. i'll give you patch a try later in the week and report back.
Please submit patches svn diff'd against branches/CONNECTORS-676. Otherwise
they will be impossible to apply.
> Connector for dropbox
> ---------------------
>
> Key: CONNECTORS-676
> URL: https://issues.apache.org/jira/browse/CONNECTORS-676
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Dropbox connector
> Affects Versions: ManifoldCF 1.1.1
> Reporter: Andrew Janowczyk
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.2
>
> Attachments: dropbox-patch.patch
>
>
> Pretty straight forward. It'd be nice to have a connector which can read from
> dropbox.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
