[jira] [Commented] (CONNECTORS-916) Amazon CloudSearch output connector

[Karl Wright (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CONNECTORS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962043#comment-13962043
 ] 

Karl Wright commented on CONNECTORS-916:
----------------------------------------

Ok.

I merged the code into the CONNECTORS-916 branch, and then rebased.  It all 
runs for me just fine.

I have some questions, however, about licensing.  I need to modify the NOTICE 
and LICENSE files to cover the new dependencies you have added:

{code} 

        <antcall target="download-via-maven"><param name="target" value="lib"/>
            <param name="project-path" value="org/ccil/cowan/tagsoup"/>
            <param name="artifact-version" value="1.2.1"/>
            <param name="artifact-name" value="tagsoup"/>
            <param name="artifact-type" value="jar"/>
        </antcall>
        
        <antcall target="download-via-maven"><param name="target" value="lib"/>
            <param name="project-path" value="com/fasterxml/jackson/core"/>
            <param name="artifact-version" value="2.1.3"/>
            <param name="artifact-name" value="jackson-databind"/>
            <param name="artifact-type" value="jar"/>
        </antcall>
        <antcall target="download-via-maven"><param name="target" value="lib"/>
            <param name="project-path" value="com/fasterxml/jackson/core"/>
            <param name="artifact-version" value="2.1.2"/>
            <param name="artifact-name" value="jackson-annotations"/>
            <param name="artifact-type" value="jar"/>
        </antcall>
{code}

I know the license for the jackson libraries, but not for tagsoup.  Do you know 
what it is?


> Amazon CloudSearch output connector
> -----------------------------------
>
>                 Key: CONNECTORS-916
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-916
>             Project: ManifoldCF
>          Issue Type: New Feature
>          Components: Amazon CloudSearch output connector
>    Affects Versions: ManifoldCF 1.7
>            Reporter: Takumi Yoshida
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 1.7
>
>         Attachments: 1.patch, 2.diff
>
>
> I wrote some codes snipetts of output connector for Amazon CloudSearch.
> I would like you to review my code. You can crawl web site and feed HTML page 
> to Amazon CloudSearch.
> but it is not perfectly completed followoing reason.
> - does not write any codes for configuration page.
> - supporting file type is only HTML
> Thank you for your time,
>  Takumi Yoshida



--
This message was sent by Atlassian JIRA
(v6.2#6252)