[
https://issues.apache.org/jira/browse/CONNECTORS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962076#comment-13962076
]
Karl Wright commented on CONNECTORS-916:
----------------------------------------
Comments on the actual code:
(1) I take it that it is these parameters that need to be configurable:
{code}
//curl -X POST --upload-file data1.json
doc.movies-123456789012.us-east-1.cloudsearch.amazonaws.com/2013-01-01/documents/batch
--header "Content-Type:application/json"
String documentEndpointUrl =
"doc-test1-hjzolhfixtfctmuaezbzinjduu.us-east-1.cloudsearch.amazonaws.com";
String urlStr = "https://"; + documentEndpointUrl +
"/2013-01-01/documents/batch";
{code}
Question: What kind of authorization is used for this? Where/how should that
be specified?
(2) For the addOrReplaceDocument() method, the error handling simply prints all
exceptions. That's not a reasonable thing to do. Exceptions should either
result in a document rejection, or a ServiceInterruption exception, or a
ManifoldCFException, depending on what you want ManifoldCF to do when it
received one.
Thanks!
> Amazon CloudSearch output connector
> -----------------------------------
>
> Key: CONNECTORS-916
> URL: https://issues.apache.org/jira/browse/CONNECTORS-916
> Project: ManifoldCF
> Issue Type: New Feature
> Components: Amazon CloudSearch output connector
> Affects Versions: ManifoldCF 1.7
> Reporter: Takumi Yoshida
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.7
>
> Attachments: 1.patch, 2.diff
>
>
> I wrote some codes snipetts of output connector for Amazon CloudSearch.
> I would like you to review my code. You can crawl web site and feed HTML page
> to Amazon CloudSearch.
> but it is not perfectly completed followoing reason.
> - does not write any codes for configuration page.
> - supporting file type is only HTML
> Thank you for your time,
> Takumi Yoshida
--
This message was sent by Atlassian JIRA
(v6.2#6252)
