[
https://issues.apache.org/jira/browse/CONNECTORS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963739#comment-13963739
]
Karl Wright commented on CONNECTORS-916:
----------------------------------------
Hi Takumi,
I've committed your latest patch to the CONNECTORS-916 branch. It looks good.
But I am a little concerned that there are error conditions this code is not
handling properly. What happens, for instance, if Amazon is not reachable due
to a network issue? That is the kind of thing that should cause a
ServiceInterruption exception to be thrown. I suspect that IOException is what
is thrown in that case. Maybe you should throw ServiceInterruption when you
see some kinds of IOExceptions? See handleIOException() in
connectors/jira/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/jira/JiraRepositoryConnector.java
for an example.
> Amazon CloudSearch output connector
> -----------------------------------
>
> Key: CONNECTORS-916
> URL: https://issues.apache.org/jira/browse/CONNECTORS-916
> Project: ManifoldCF
> Issue Type: New Feature
> Components: Amazon CloudSearch output connector
> Affects Versions: ManifoldCF 1.7
> Reporter: Takumi Yoshida
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.7
>
> Attachments: 1.patch, 2.diff, exception_handling.diff
>
>
> I wrote some codes snipetts of output connector for Amazon CloudSearch.
> I would like you to review my code. You can crawl web site and feed HTML page
> to Amazon CloudSearch.
> but it is not perfectly completed followoing reason.
> - does not write any codes for configuration page.
> - supporting file type is only HTML
> Thank you for your time,
> Takumi Yoshida
--
This message was sent by Atlassian JIRA
(v6.2#6252)
