> -----Original Message-----
> From: Brett Porter [mailto:[EMAIL PROTECTED]
> Sent: 16 June 2003 07:21
> To: Maven Developers List
> Subject: Re: New feature: filtering
>
> > Why is that? I never use the "overwrite" attribute and all my
filtering
> > work fine...
>
> change a filter, but don't touch the file that will be filtered - Ant
> (at least last time I checked) doesn't copy the file again, leaving it
> with the old value.
>
> >
> > BTW, do you have any idea why the sample-filtering project in
> > plugin-builds/examples does not work WRT filtering?
> >
>
> Haven't looked - I'll check it out when I have a chance.
>
> > Hmmm.... Not sure. It seems to me that it is complicating the POM
quite
> > a bit. Also, I'd prefer the following format:
> >
> > <resource>
> > <filters>
> > <filter>
> > <token/>
> > <value/>
> > </filter>
> > </filters>
> > [...]
> > </resource>
> >
> > I'm curious to see what other think.
>
> I have ~100 tokens to filter in our large project. I think that might
> complicate the POM more :)
>
> I've happy to just have a yes/no flag for filtering, as long as you
can
> specify a list of files and/or tokens to read them from. I just
thought
> the filterset solution was as clean, and allowed finer-grained control
> if you need it.
>
oh, ok. I thought you wanted to put the filter in the POM... If it's
just the filtersets, then, yes I agree. However, I'm not sure I like the
format:
<resources>
<filters>
<id>my.filters</id>
<directory>${basedir}/../filters</directory>
<includes>
<include>**/*.properties</include>
</includes>
</filters>
<resource>
<filtersets>
<filterset>my.filters</filterset>
<filterset>base.filters</filterset>
</filtersets>
...
</resource>
[...]
I much prefer:
<resources>
<resource>
<filtering>true</filtering>
<filtersets>
<filterset>filtersetid1</filterset>
<filterset>filtersetid2</filterset>
</filtersets>
<directory>${basedir}/../filters</directory>
<includes>
<include>**/*.properties</include>
</includes>
</resource>
[...]
Where filtersetid1 is a filter set id defined somewhere in the project's
maven.xml
-Vincent
> Cheers,
> Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
