> -----Original Message----- > From: Jason van Zyl [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 10:35 > To: Maven Developers List > Subject: Re: New feature: filtering > > On Mon, 2003-06-16 at 03:20, Brett Porter wrote: > > > oh, ok. I thought you wanted to put the filter in the POM... If it's > > > just the filtersets, then, yes I agree. However, I'm not sure I like > the > > > format: > > > > > > <resources> > > > <filters> > > > <id>my.filters</id> > > > <directory>${basedir}/../filters</directory> > > > <includes> > > > <include>**/*.properties</include> > > > </includes> > > > </filters> > > > <resource> > > > <filtersets> > > > <filterset>my.filters</filterset> > > > <filterset>base.filters</filterset> > > > </filtersets> > > > ... > > > </resource> > > > [...] > > > > > > I much prefer: > > > > > > <resources> > > > <resource> > > > <filtering>true</filtering> > > > <filtersets> > > > <filterset>filtersetid1</filterset> > > > <filterset>filtersetid2</filterset> > > > </filtersets> > > > <directory>${basedir}/../filters</directory> > > > <includes> > > > <include>**/*.properties</include> > > > </includes> > > > </resource> > > > [...] > > > > > > > I'm happy either way - its just a matter of whether filters get into the > > POM or just maven.xml. > > I would be much happier with the filters being setup in the POM or > something that has nothing to do with Ant. I was going to port the > resource handling code to a small Java class because the expression > handling with Jexl is very brittle. While trying to make some very > simple changes things are breaking and I'm finding it's just easier to > make a small Java class than fight with Jelly all day. I realize most of > my problems are with Jexl but moving this code to Java is much simpler. > > If you can figure out how you want to specify the filters I have the > code to handle copying resources with @FOO@ type tokens within. > > I'm not fussy about the syntax but I do not want to bind the filtering > to Ant.
Jason, I have some trouble following your line of thought. Ant is java based: http://cvs.apache.org/viewcvs.cgi/ant/src/main/org/apache/tools/ant/filt ers/ http://cvs.apache.org/viewcvs.cgi/ant/src/main/org/apache/tools/ant/type s/ http://cvs.apache.org/viewcvs.cgi/ant/src/main/org/apache/tools/ant/task defs/Filter.java And you can re-use any of these without having to go through an XML script file of course. Why would you want to reinvent the wheel? Thanks -Vincent > > -- > jvz. > > Jason van Zyl > [EMAIL PROTECTED] > http://tambora.zenplex.org > > In short, man creates for himself a new religion of a rational > and technical order to justify his work and to be justified in it. > > -- Jacques Ellul, The Technological Society > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
