oh, ok. I thought you wanted to put the filter in the POM... If it's just the filtersets, then, yes I agree. However, I'm not sure I like the format:
<resources>
<filters>
<id>my.filters</id>
<directory>${basedir}/../filters</directory>
<includes>
<include>**/*.properties</include>
</includes>
</filters>
<resource>
<filtersets>
<filterset>my.filters</filterset>
<filterset>base.filters</filterset>
</filtersets>
...
</resource> [...]
I much prefer:
<resources> <resource> <filtering>true</filtering> <filtersets> <filterset>filtersetid1</filterset> <filterset>filtersetid2</filterset> </filtersets> <directory>${basedir}/../filters</directory> <includes> <include>**/*.properties</include> </includes> </resource> [...]
I'm happy either way - its just a matter of whether filters get into the POM or just maven.xml.
However, I'd leave <filtering> out if there is filtersets - as you can derive filtering from !filtersets.isEmpty()
Also, you didn't put overwrite="true" into the copy in the cvs commit I noticed. To see what I mean, try this:
----- snip -----
$ maven java:jar-resources
...
$ cat target/classes/test.properties
# A simple config file with an Ant filter
test.property = it worked! ----- snip ----- Now edit maven.xml so the property is "it still works!", and run again ----- snip ----- $ maven java:jar-resources ... $ cat target/classes/test.properties # A simple config file with an Ant filter
test.property = it worked! ----- snip -----
You need the overwrite flag :)
Cheers, Brett
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
